Question: atsha204 driver upstreaming

security
kernel

#1

Hi Turris Omnia Team,

First of all, thank you for your work on the router and making the project a reality.

I know that Turris OS kernel carries an out-of-tree module to support atsha204 crypto chip (https://gitlab.labs.nic.cz/turris/turris-omnia-uboot/blob/omnia/drivers/misc/atsha204-i2c.c, seems to be based on cryptotronix/atsha204-i2c) and some userspace bits (libatsha204 and modifications to init scripts) to make it usable as an entropy source. If openwrt is used on Turris Omnia, the kernel entropy pool is not filled which leads to blocking getrandom(2) calls https://bugs.openwrt.org/index.php?do=details&task_id=1979.

Are there any plans to upstream this driver to reduce the delta with upstream kernel and openwrt as a result? Any blockers (besides dev time) for making this happen?


#2

There is no driver in the kernel for this chip. u-boot has one to get the mac addresses from there. Under Linux there is only the userspace software that runs early in the boot sequence. It simply requests entropy from the chip and sends it to the kernel by running atsha204cmd feed-entropy.


#3

@adminX

Right, it’s the uboot one which I confused with this https://github.com/cryptotronix/atsha204-i2c - I guess I got the answer to my question because it is not related to the work the Turris team was doing.