Maxmilian's notes on smb.conf

Setup for Samba client on Win10 version 1709

ControlPanel>NetworkAndInternet>NetworkAndSharingCenter>AdvancedSharingSettings:
- ensure that network adapter used for connection has profile set 

PRIVATE profile
NetworkDiscovery

NetworkDiscovery ON
- Turn On Automatic setup of network connected devices
FileAndPrinterShareing
Turn On File and Printer Sharing
HomeGroupConnections

Allow Windows to manage homegroup connections (recommended)
- As you have TOS as samba server you do not want Windows to manage the homegroup connection. Especially if you have dedicated samba_user on TOS defined.
- But seems that recommended mode has no effect if you want one user or more.
Guest or Public profile (all off/disabled)
All Networks profile (all off/disabled)

ControlPanel>NetworkAndInternet>NetworkAndSharingCenter>HomeGroup
- It is not necessary to join the group if all works fine with TOS set to WORKGROUP
- If you are facing some issues, connect that win-client to your samba group. 
- Once you have it working change WORKGROUP to something else

Firewall
- Check profile “private network” for open ports 
- You should have several rules predefined, just allow them 
SMB1 >> UDP: 137,138 TCP:139,445
SMB2 >> UDP: TCP:445
- Based on TOS setup of min/max protocol , choose right set(s)
workgroup

If you can define own homegroup name, do not use default WORKGROUP.
Members of group are having higher rights, non-members are having some restrictions.
There might be situation when you have legit user from WORKGROUP and non-legit user from another WORKGROUP.
Invalid user will be threated like guest (that’s why it is better to disable guest in general) from Workgroup and actually gets browse permissions.
So such user will see your share. And i think you do not want your guest (with win10 OS in default setup to browse your shares)

2 Likes