Adblock package release for turris omnia

EDIT: I resolved this – it’s not a bug, it is a “feature”…

@dibdot I believe there is some bug in processing manual blacklist.

Steps to reproduce:

  1. AdBlock web administration

  2. on the Overview tab, uncheck all Blocklist Sources

  3. hit Save & Apply

  4. go to the console and check, that the /etc/kresd/adb_list.overall file is empty (which is expected):

    wc -l /etc/kresd/adb_list.overall

    0 /etc/kresd/adb_list.overall
    
  5. then go back to the AdBlock web administration -> Advanced -> Edit Blacklis and add any records, e.g.:

    u.scdn.co
    *.u.scdn.co

  6. hit Save. You can check, that the content of /etc/adblock/adblock.blacklist file is correctly saved

  7. go back to Overview tab and hit Save & Apply (so that AdBlock will restart).

  8. check the /var/log/messages, that adblock restarted successfully:

    notice adblock-[3.0.2]: info : block list with overall 0 domains loaded successfully (Turris Omnia, OpenWrt omnia 15.05/3.8)

The problem: file /etc/kresd/adb_list.overall is still empty:

Expected behavior: file /etc/kresd/adb_list.overall would contain those 2 blacklisted domains.

Am I doing something wrong? Or is it a bug that could be fixed in the package?

EDIT: It’s not a bug – it was my fault :frowning:
The manual blacklist works only if you select blacklist among other Blocklist Sources – which is not very intuitive, but it is how it is.